Commit Diff

Commit:
9ce0b9cb39a3c98b9bf3332da7ce5c81be292fc6
From:
ale <ale_bnes@tuta.com>
Date:
Message:
Fix: build docs step needs GITHUB_TOKEN even without deploydocs Removing deploydocs also removed GITHUB_TOKEN from the build step, reasoning it was only needed for the git push. Wrong: makedocs itself decides "dev" vs root base path from Documenter's deploy-criteria check, which needs the token present to pass. Without it, the first real deploy built for root, breaking every asset path once nested under dev/ (a real, live, unstyled site — traced via the run's own log showing "Deploying: ✘" and Bases that will be built: [""]).
Actions:
Patch | Tree
commit - e88ae7c6d7c509d34868a01984b5cfdc694dc89e
commit + 9ce0b9cb39a3c98b9bf3332da7ce5c81be292fc6
blob - d1d8185fadee01064844666059fbec39444dffab
blob + c01d834367a6be80b182a395732ad8d6d9174403
--- .github/workflows/Documenter.yml
+++ .github/workflows/Documenter.yml
@@ -34,11 +34,14 @@ jobs:
         id: julia-cache
         uses: julia-actions/cache@v3
       - name: Build docs
-        # Despite the name, this action doesn't deploy anything itself —
-        # it just runs docs/make.jl (which no longer calls `deploydocs` at
-        # all; see its top comment).
+        # docs/make.jl doesn't call deploydocs anymore, but GITHUB_TOKEN is
+        # still needed: makedocs itself picks the "dev" vs root base path
+        # from Documenter's deploy-criteria check, which requires it — a
+        # real deploy without it built for root and 404'd every asset once
+        # nested under dev/ below.
         uses: julia-actions/julia-docdeploy@v1
         env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
           JULIA_DEBUG: "Documenter"
       - name: Save Julia depot cache on cancel or failure
         if: cancelled() || failure()